Fix some incorrect include statements. #2526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replacing without reordering quote includes to angle bracket includes where appropriate. The following logic is used to find the incorrect includes: find #include "kj/ find #include "capnp/ find #include "workerd/ find #include "v8- // AND the header is in the v8 include directory find #include "openssl/ find #include ".*?/.* // Not all of these are wrong find #include c system headers // replace <stdint.h> with <cstdint>
anonrig
approved these changes
Aug 13, 2024
jasnell
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing without reordering quote includes to angle bracket includes where appropriate.
The following logic is used to find the incorrect includes:
find #include "kj/
find #include "capnp/
find #include "workerd/
find #include "v8- // AND the header is in the v8 include directory
find #include "openssl/
find #include ".?/. // Not all of these are wrong
find #include c system headers // replace <stdint.h> with
If we decide to enable sortincludes in clang-format this should fix some incorrect grouping.